[Locale] updated StubIntlDateFormatter::format() behavior for PHP >= 5.3.4 #3840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a feature addition as opposed to a bug fix and if so, should probably go in the master branch rather than 2.0. |
|
@Drak it is a bug fix as the stub is meant to have the same behavior than the real intl |
|
ok, thanks for the clarification, I wasnt sure. |
|
@stof is right. I myself fixed it in master and then remembered that bug fixes should be made in 2.0. |
fabpot
added a commit
that referenced
this pull request
Apr 9, 2012
Commits ------- 31dde14 [Locale] updated StubIntlDateFormatter::format() behavior for PHP >= 5.3.4 Discussion ---------- [Locale] updated StubIntlDateFormatter::format() behavior for PHP >= 5.3.4 Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: - [](http://travis-ci.org/eriksencosta/symfony) --------------------------------------------------------------------------- by drak at 2012-04-08T23:20:20Z This looks like a feature addition as opposed to a bug fix and if so, should probably go in the master branch rather than 2.0. --------------------------------------------------------------------------- by stof at 2012-04-08T23:30:25Z @Drak it is a bug fix as the stub is meant to have the same behavior than the real intl --------------------------------------------------------------------------- by drak at 2012-04-08T23:36:08Z ok, thanks for the clarification, I wasnt sure. --------------------------------------------------------------------------- by eriksencosta at 2012-04-08T23:44:22Z @stof is right. I myself fixed it in master and then remembered that bug fixes should be made in 2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -