8000 [Security] Log notice when no entry point is configured by wouterj · Pull Request #38220 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] Log notice when no entry point is configured #38220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2020
Merged

[Security] Log notice when no entry point is configured #38220

merged 1 commit into from
Sep 17, 2020

Conversation

wouterj
Copy link
Member
@wouterj wouterj commented Sep 17, 2020
Q A
Branch? 5.1
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #37068
License MIT
Doc PR -

In the new security system, authenticators are not necessarily authentication entry points. This can cause unexpected behavior if no entry point is configured. It's not really an error, that's why I choose the "notice" level: "Normal but significant events".

@fabpot
Copy link
Member
fabpot commented Sep 17, 2020

@wouterj Can you check the tests (they are broken by this change)?

@wouterj wouterj force-pushed the issue-37068/log-no-entry-point branch from 48fec71 to 4193931 Compare September 17, 2020 09:33
linaori
linaori reviewed Sep 17, 2020
View reviewed changes
@wouterj wouterj force-pushed the issue-37068/log-no-entry-point branch from 4193931 to 68f891f Compare September 17, 2020 09:51
@fabpot
Copy link
Member
fabpot commented Sep 17, 2020

Thank you @wouterj.

@fabpot fabpot merged commit 4d1a522 into symfony:5.1 Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linaori linaori linaori left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wouterj @fabpot @linaori @carsonbot
< 3191 div hidden> Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
0