8000 [String] improve slugger's portability accross implementations of iconv() by nicolas-grekas · Pull Request #38195 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[String] improve slugger's portability accross implementations of iconv() #38195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2020
Merged

[String] improve slugger's portability accross implementations of iconv() #38195

merged 1 commit into from
Sep 16, 2020

Conversation

nicolas-grekas
Copy link
Member
@nicolas-grekas nicolas-grekas commented Sep 15, 2020 •
edited
Loading
Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #36880, fix #38060
License MIT
Doc PR -

Ping @Surfoo @edguar, can you please confirm that this fixes your issues?

@nicolas-grekas nicolas-grekas added this to the 5.1 milestone Sep 15, 2020
@nicolas-grekas nicolas-grekas changed the title [String] improve slugger's portability accross implementations of ico… [String] improve slugger's portability accross implementations of iconv() Sep 15, 2020
@kdambekalns
Copy link

I'd love to help, but none of the linked issues are known to me… 🤷‍♂️

@nicolas-grekas
Copy link
Member Author

Oups sorry @kdambekalns , bad ping.

@edguar could you please have a look?

@notFloran notFloran mentioned this pull request Sep 15, 2020
Closed
@Surfoo
Copy link
Surfoo commented Sep 15, 2020

Hello @nicolas-grekas,

Works for me, thank you!

Just for my curiosity, why don't you have some unit tests on a matrix of differents environments?

@nicolas-grekas
Copy link
Member Author

Having a matrix of possible iconv implementations looks impossible to me. That's a zoo I know nothing about...

@fabpot
Copy link
Member
fabpot commented Sep 16, 2020

Thank you @nicolas-grekas.

@fabpot fabpot merged commit f27ca4e into symfony:5.1 Sep 16, 2020
@fabpot fabpot mentioned this pull request Sep 27, 2020
Merged
@nicolas-grekas nicolas-grekas deleted the str-translit branch October 2, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review String
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @kdambekalns @Surfoo @fabpot @carsonbot
0