[Console] Exception rendering fixes #3802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Apr 6, 2012
Commits ------- 595cc11 [Console] Wrap exception messages to the terminal width to avoid ugly output 97f7b29 [Console] Avoid outputing \r's in exception messages Discussion ---------- [Console] Exception rendering fixes This fixes two things: - `\r`'s in exception messages were output (in case of `\r\n` newlines), creating really weird results on windows. - long exception messages were wrapping and then the "red" block was completely messed up, with half black/half red lines, now it's wrapped before output if the terminal width can be detected. If you don't care about merging this for 2.0, you can also merge the `console_ex` branch which applies on master. Due to moving tests and renaming of some normalize stuff in the tests, the two test patches are kind of different. RFC: I am really not sure where to put those getTerminalWidth/Height methods. I guess this is not the best place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two things:
\r's in exception messages were output (in case of\r\nnewlines), creating really weird results on windows.If you don't care about merging this for 2.0, you can also merge the
console_exbranch which applies on master. Due to moving tests and renaming of some normalize stuff in the tests, the two test patches are kind of different.RFC: I am really not sure where to put those getTerminalWidth/Height methods. I guess this is not the best place.