[PhpUnitBridge] Create a predictable symlink pointing to the local install #37974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
488da3e to
05b1099
Compare
nicolas-grekas
approved these changes
Aug 28, 2020
05b1099 to
1f5dc8e
Compare
chalasr
approved these changes
Aug 28, 2020
yceruto
approved these changes
Aug 28, 2020
fabpot
approved these changes
Aug 28, 2020
|
Thank you @dunglas. |
539870d to
bf7654f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static analysis tools such as PHPStan need to be able to autoload classes provided by to work. It's also useful to use the assertions provided by PHPUnit with other testing tools such as Behat.
When using
simple-phpunit, PHPUnit isn't installed in thevendor/directory, consequently other tools cannot autoload its classes.A workaround is to configure these tools to load the autoloader installed by
simple-phpunit. Example with PHPstan:However, the path of the autoloader isn't predictable: it depends of PHPUnit version.
This PR changes
simple-phpunitto create a symlink with a predictable path (vendor/.phpunit/phpunit) pointing to the currently used version of PHPUnit, so it is possible to hardcode this value in config files.The symlink is recreated before every run, so if a different version of PHPUnit must be used because the PHP version in use is different from the previous run (frequent when developing libraries compatible with multiple PHP versions), it still works.