8000 Improve link script with rollback when using symlink by noniagriconomie · Pull Request #37915 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Improve link script with rollback when using symlink #37915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2020
Merged

Improve link script with rollback when using symlink #37915

merged 1 commit into from
Aug 22, 2020

Conversation

noniagriconomie
Copy link
Contributor
@noniagriconomie noniagriconomie commented Aug 21, 2020 •
edited
Loading
Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets Improve when dev symfony/symfony with local project
License MIT
Doc PR .

Hi, this just rollback the local project state when finishing testing via symlink (default)

@fabpot
Copy link
Member
fabpot commented Aug 22, 2020

Thank you @noniagriconomie.

@fabpot fabpot merged commit d4c8be7 into symfony:master Aug 22, 2020
@fabpot fabpot mentioned this pull request Aug 22, 2020
Closed
@noniagriconomie noniagriconomie deleted the feature-link-symlink-rollback branch August 22, 2020 09:13
@ogizanagi ogizanagi mentioned this pull request Aug 26, 2020
Merged
fabpot added a commit that referenced this pull request Aug 26, 2020
@fabpot
minor #37952 Backport: Improve link script with rollback when using s…
a430ccb 
…ymlink (noniagriconomie)

This PR was merged into the 3.4 branch.

Discussion
----------

Backport: Improve link script with rollback when using symlink

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | N/A <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | N/A

Backports #37915 to 3.4.

Even if it's a new feature, it's a contributors tool that can be used for any version to try out.

Commits
-------

ab92e9f Backport: Improve link script with rollback when using symlink
@fabpot fabpot mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noniagriconomie @fabpot @carsonbot
0