8000 [Mailer] Support Return-Path in SesApiAsyncAwsTransport by cvmiert · Pull Request #37913 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mailer] Support Return-Path in SesApiAsyncAwsTransport #37913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2020
Merged

[Mailer] Support Return-Path in SesApiAsyncAwsTransport #37913

merged 1 commit into from
Aug 23, 2020

Conversation

cvmiert
Copy link
@cvmiert cvmiert commented Aug 21, 2020
Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

Enable sending SendEmailRequests with a Return-Path configured in
SesApiAsyncAwsTransport.

@cvmiert cvmiert force-pushed the amazon-mailer/api-async-transport-support-return-path branch from 61de269 to 47ef3a9 Compare August 21, 2020 14:27
@fabpot
Copy link
Member
fabpot commented Aug 22, 2020

Can you have a look at the tests and fix them?

[Mailer] Support Return-Path in SesApiAsyncAwsTransport
61754cb 
Enable sending `SendEmailRequest`s with a `Return-Path` configured in
`SesApiAsyncAwsTransport`.
@cvmiert cvmiert force-pushed the amazon-mailer/api-async-transport-support-return-path branch from 47ef3a9 to 61754cb Compare August 22, 2020 11:42
@cvmiert
Copy link
Author
cvmiert commented Aug 22, 2020

Can you have a look at the tests and fix them?

I am not quite sure how to fix that one failing Travis build. The tests would fail specifically on this assertion before #37888 got accepted. Could it be that the code that build is running against is somehow not completely up to date?

@fabpot
Copy link
Member
fabpot commented Aug 23, 2020

Thank you @cvmiert.

@fabpot fabpot merged commit 6adb667 into symfony:5.1 Aug 23, 2020
@fabpot fabpot mentioned this pull request Aug 31, 2020
Merged
@xabbuh xabbuh added this to the 5.1 milestone Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Mailer Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@cvmiert @fabpot @xabbuh @carsonbot
0