8000 [Mailer] Support Amazon SES ConfigurationSetName by cvmiert · Pull Request #37897 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Mailer] Support Amazon SES ConfigurationSetName #37897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cvmiert
Copy link
@cvmiert cvmiert commented Aug 20, 2020
Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

In Amazon SES a Configuration Set can be used to monitor email sending
events (delivery, bounces, complaints etc.). In order to use this
feature the ConfigurationSetName needs to be sent along with the email.

Setting the X-SES-CONFIGURATION-SET header should accomplish this for
all SES Transports now.

Ref: https://docs.aws.amazon.com/ses/latest/DeveloperGuide/using-configuration-sets-in-email.html

@fabpot
Copy link
Member
fabpot commented Aug 21, 2020

Apparently, this is supported by other transports like SMTP, can you fix all SES transports?.

@cvmiert cvmiert force-pushed the amazon-mailer/add-configuration-set-name-support branch 2 times, most recently from 6e6f9f2 to bee64fb Compare August 21, 2020 13:47
In Amazon SES a Configuration Set can be used to monitor email sending
events (delivery, bounces, complaints etc.). In order to use this
feature the ConfigurationSetName needs to be sent along with the email.

Setting the `X-SES-CONFIGURATION-SET` header should accomplish this for
all SES Transports now.

Ref: https://docs.aws.amazon.com/ses/latest/DeveloperGuide/using-configuration-sets-in-email.html
@cvmiert cvmiert force-pushed the amazon-mailer/add-configuration-set-name-support branch from bee64fb to a36fec3 Compare August 21, 2020 13:49
@cvmiert
Copy link
Author
cvmiert commented Aug 21, 2020

Apparently, this is supported by other transports like SMTP, can you fix all SES transports?.

Sure thing, just pushed the code for that!

Since I don't think these changes break BC, could we consider getting this into the 5.1 branch instead? If so, I'm happy to rebase the PR against that branch.

Copy link
Member
@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a new feature, it will be merged in master.

@fabpot
Copy link
Member
fabpot commented Aug 22, 2020

Thank you @cvmiert.

@fabpot fabpot merged commit f1d1514 into symfony:master Aug 22, 2020
@xabbuh xabbuh added this to the next milestone Aug 26, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
@fabpot fabpot mentioned this pull request Oct 5, 2020
@deleugpn
Copy link

Is there any documentation regarding this change? I'm investingating how to upgrade to Laravel 9 and this is the missing part where I can't figure out how to integrate with Symfony Mailer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0