8000 Fix the parameter names in the SecurityFactoryInterface::create() method by leofeyer · Pull Request #37869 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix the parameter names in the SecurityFactoryInterface::create() method #37869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2020
Merged

Fix the parameter names in the SecurityFactoryInterface::create() method #37869

merged 1 commit into from
Aug 18, 2020

Conversation

leofeyer
Copy link
Contributor
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

With regard to PHP 8, Psalm has added a named arguments check:
https://psalm.dev/articles/getting-ready-for-named-arguments

This check currently fails, because the SecurityFactoryInterface uses different parameter names than the AbstractFactory. You can see for yourselves at https://psalm.dev/r/81413a1c96.

@fabpot
Copy link
Member
fabpot commented Aug 18, 2020

Thank you @leofeyer.

@fabpot fabpot merged commit 5d88798 into symfony:4.4 Aug 18, 2020
@leofeyer leofeyer deleted the fix/security-factory-interface branch August 18, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leofeyer @fabpot @carsonbot
0