10000 [FrameworkBundle] Fix error in xsd by l-vo · Pull Request #37852 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[FrameworkBundle] Fix error in xsd #37852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Conversation

l-vo
Copy link
Contributor
@l-vo l-vo commented Aug 17, 2020

Probably occured during merge

Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Fix xsd error, I think that's happened after #37849, during the merge in upper branches.

Probably occured during merge
@fabpot
Copy link
Member
fabpot commented Aug 17, 2020

Thank you @l-vo.

@fabpot fabpot merged commit 5534811 into symfony:master Aug 17, 2020
@l-vo
Copy link
Contributor Author
l-vo commented Aug 17, 2020

@fabpot @ogizanagi It seems the tests are still broken, I'm looking if there is another problem.

@l-vo l-vo deleted the fix_merge_problem_xsd branch August 17, 2020 09:59
@l-vo
Copy link
Contributor Author
l-vo commented Aug 17, 2020

Ok I saw the problem, the headers was not present in 4.4, so the test should be updated. I created another PR ( #37854) to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0