8000 [Security] [HttpDigest] Fixes a configuration error caused by an invalid "key" child node configuration by ruimarinho · Pull Request #3778 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] [HttpDigest] Fixes a configuration error caused by an invalid "key" child node configuration #3778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2012
Merged

[Security] [HttpDigest] Fixes a configuration error caused by an invalid "key" child node configuration #3778

merged 1 commit into from
Apr 4, 2012

Conversation

ruimarinho
Copy link 
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes

fabpot added a commit that referenced this pull request Apr 4, 2012
@fabpot
merged branch ruimarinho/http_digest (PR #3778)
eb6a26f 
Commits
-------

fd1ea69 [Security] [HttpDigest] Fixes a configuration error caused by an invalid key child node configuration

Discussion
----------

[Security] [HttpDigest] Fixes a configuration error caused by an invalid "key" child node configuration

```
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
```
@fabpot fabpot merged commit fd1ea69 into symfony:2.0 Apr 4, 2012
fabpot added a commit that referenced this pull request Apr 4, 2012
@fabpot
Revert "merged branch ruimarinho/http_digest (PR #3778)"
e4ebffb 
This reverts commit eb6a26f, reversing
changes made to a10fee1.
@fabpot
Copy link
Member
fabpot commented Apr 4, 2012

reverted as tests do not pass. Please, run the tests before submitting a PR.

@ruimarinho
Copy link
Author

@fabpot re-submitted as #3781. My local tests report 26 failures due to bogus ICU data - already started some work on fixing this (see #3748) - sorry, but I missed the PR failures in there. The new one is using Travis to make sure everything is correct.

Sign up for free to join this conversation on GitHub. 5918 Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruimarinho @fabpot
0