10000 [FrameworkBundle] Add days before expiration in "about" command by noniagriconomie · Pull Request #37754 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Add days before expiration in "about" command #37754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2020
Merged

[FrameworkBundle] Add days before expiration in "about" command #37754

merged 1 commit into from
Aug 9, 2020

Conversation

noniagriconomie
Copy link
Contributor
@noniagriconomie noniagriconomie commented Aug 6, 2020 •
edited
Loading
Q A
Branch? master
Bug fix? no
New feature? yes (with RFC)
Deprecations? no
Tickets Slack discussion + see RFC below
License MIT
Doc PR

Maybe this can be usefull in the bin/console about output.
Following a small discussion on Slack

See discussion sf_slack

Symfony 5.1 output:
sf51

Symfony 5.foo_bar output:
With:

    // symfony/http-kernel/Kernel.php
    const END_OF_MAINTENANCE = '08/2020'; // this month
    const END_OF_LIFE = '09/2020'; // next month

sf51_fake

RFC #

Is there a way in Symfony land packages to have such info or/and in Composer in general? the EOL of a package version.

Like for example the https://github.com/FriendsOfPHP/security-advisories Security Advisories feature,
but for End Of Life Advisories where packages maintainers can add their packages, and this data can be read by composer or an other command

Or maybe directly inside the composer.json, like an "eol": "true" // and false by default if not defined (not possible, see below)

Thanks

YaFou
YaFou approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor
@YaFou YaFou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to remove the +.

@stof
Copy link
Member
stof commented Aug 6, 2020

Or maybe directly inside the composer.json, like an "eol": "true" // and false by default if not defined

that won't help. You cannot alter the composer.json of a release after it is done (git tags are immutable) so you cannot make that change at the time of the eol.
Also, the EOL of a release is generally at the time of releasing the next patch release for the same minor. What maintenance process have generally is an EOL date for minor and major versions, not for each package version.

@noniagriconomie
Copy link
Contributor Author
noniagriconomie commented Aug 6, 2020 •
edited
Loading

@stof

I see your point arround the tag and the release

And do you think the:

Like for example the Security Advisories feature

could help achieve such feature of knowing the EOL of a feature?
Maybe an internal mapping inside composer land (or community and composer plugin support) ?

@domgraziano
Copy link

@stof

I see your point arround the taf and the release

And do you think the:

Like for example the Security Advisories feature

could help achieve such feature of knowing the EOL of a feature?
Maybe an internal mapping inside composer land (or community and composer plugin support) ?

Hi, what about a brand new option shipped with the current about command that checks if the current version is EOL, and throws error if it is. I imagine a php bin/console about --eol_check that could be easily used by anyone to validate during CI.

@noniagriconomie noniagriconomie changed the title Add days before expiration in "about" command [FrameworkBundle] Add days before expiration in "about" command Aug 7, 2020
@fabpot
Copy link
Member
fabpot commented Aug 9, 2020

Thank you @noniagriconomie.

@fabpot fabpot mentioned this pull request Aug 9, 2020
Closed
@fabpot fabpot merged commit 4664adb into symfony:master Aug 9, 2020
@noniagriconomie noniagriconomie deleted the feature-command-about-expiration branch August 9, 2020 09:08
@noniagriconomie
Copy link
Contributor Author
noniagriconomie commented Aug 9, 2020 •
edited
Loading

@fabpot regarding the RFC part of this PR,

do you suggest opening a specific issue in /symfony or /composer to keep the discussion goingis usefull?

many thanks

edit: issue opened at /composer ⬇️

@noniagriconomie noniagriconomie mentioned this pull request Aug 10, 2020
Closed
@domgraziano domgraziano mentioned this pull request Aug 17, 2020
Closed
@fabpot fabpot mentioned this pull request Oct 5, 2020
Merged
@94noni 94noni mentioned this pull request Oct 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

@YaFou YaFou YaFou approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@noniagriconomie @stof @domgraziano @fabpot @YaFou @carsonbot
0