8000 [Routing] Added the possibility to define options for imported resources by stof · Pull Request #3775 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Routing] Added the possibility to define options for imported resources #3775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2012
Merged

[Routing] Added the possibility to define options for imported resources #3775

merged 1 commit into from
Apr 4, 2012

Conversation

stof
Copy link
Member
@stof stof commented Apr 4, 2012

Closes #2772

fabpot added a commit that referenced this pull request Apr 4, 2012
@fabpot
merged branch stof/routing_options_import (PR #3775)
71c9dc3 
Commits
-------

3c32569 [Routing] Added the possibility to define options for imported resources

Discussion
----------

[Routing] Added the possibility to define options for imported resources

Closes #2772
@fabpot fabpot merged commit 3c32569 into symfony:master Apr 4, 2012
@kbond
Copy link
Member
kbond commented Apr 4, 2012

What about options for routing resolvers?

@stof
Copy link
Member Author
stof commented Apr 4, 2012

@kbond what are you talking about ?

@kbond
Copy link
Member
kbond commented Apr 4, 2012

looked a little further and it is a separate issue. i have had need to include options for a custom routing loader - ie:

_imagine:
    resource: .
    type:     imagine
    options: [foo, bar]

At first glance I thought this PR solved that.

@stof
Copy link
Member Author
stof commented Apr 4, 2012

this is exactly what the PR is about

@kbond
Copy link
Member
kbond commented Apr 13, 2012

@stof hmm, in my example above, where would the options array be available - it isn't available in the ImagineLoader. You would have to load the yaml file to get it (I think this is what the FOSRestBundle does)

@stof
Copy link
Member Author
stof commented Apr 13, 2012

@kbond they are available in the route after they are merged in the parent collection (same than the prefix, the requirements or the defaults)

@kbond
Copy link
Member
kbond commented Apr 13, 2012

I see, so you can't use these options when creating the routes with a loader?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibility to add options for imported resource
3 participants
@stof @kbond @fabpot
0