10000 [Serializer] Fix that it will never reach DOMNode by TNAJanssen · Pull Request #37701 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] Fix that it will never reach DOMNode #37701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2020
Merged

[Serializer] Fix that it will never reach DOMNode #37701

merged 1 commit into from
Aug 4, 2020

Conversation

TNAJanssen
Copy link
Contributor
@TNAJanssen TNAJanssen commented Jul 29, 2020 •
edited
Loading
Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT
Doc PR

When providing the DOMNode object, the is_object check will return true. This way it will never reach the DOMNode check.

So i moved this check to above the is_object check.

@TNAJanssen TNAJanssen requested a review from dunglas as a code owner July 29, 2020 15:07
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jul 30, 2020
@nicolas-grekas
Copy link
Member

Could you please add a test case?

@TNAJanssen
Copy link
Contributor Author

Sure, will do that on monday:)

@fabpot
Copy link
Member
fabpot commented Aug 4, 2020

Thank you @TNAJanssen.

@fabpot fabpot merged commit 995d784 into symfony:3.4 Aug 4, 2020
This was referenced Aug 31, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug Serializer Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@TNAJanssen @nicolas-grekas @fabpot @xabbuh @carsonbot
0