8000 [Cache] fix saving no-expiry items with ArrayAdapter by philipp-kolesnikov · Pull Request #37671 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Cache] fix saving no-expiry items with ArrayAdapter #37671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2020
Merged

[Cache] fix saving no-expiry items with ArrayAdapter #37671

merged 1 commit into from
Jul 31, 2020

Conversation

philipp-kolesnikov
Copy link
Contributor
Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #37667
License MIT
Doc PR

0 is a special value that means "infinity".

@xabbuh xabbuh added the Cache label Jul 26, 2020
@alongosz alongosz mentioned this pull request Jul 27, 2020
Closed
@alongosz
Copy link

Hi. Our product - eZ Platform - is affected by that as well.
I've checked this fix with our CI and can confirm it solves the issue. Thanks :)

@xabbuh xabbuh added this to the 3.4 milestone Jul 27, 2020
@nicolas-grekas nicolas-grekas changed the title Fixes #37667 [Cache] fix saving no-expiry items with ArrayAdapter Jul 29, 2020
nicolas-grekas
nicolas-grekas reviewed Jul 29, 2020
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.
Would it be possible to add another test case in AdapterTestCase that hit the bug without using TagAwareAdapter?

@fabpot
Copy link
Member
fabpot commented Jul 31, 2020

Thank you @philipp-kolesnikov.

@fabpot fabpot merged commit b61fa44 into symfony:3.4 Jul 31, 2020
@nicolas-grekas nicolas-grekas mentioned this pull request Aug 26, 2020
Closed
This was referenced Aug 31, 2020
Merged
Merged
Merged
@dmaicher dmaicher mentioned this pull request Sep 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Cache Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@philipp-kolesnikov @alongosz @fabpot @nicolas-grekas @xabbuh @carsonbot
0