8000 [EventDispatcher] Minor: Avoid not needed null check in dispatch() by brainexe · Pull Request #37669 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[EventDispatcher] Minor: Avoid not needed null check in dispatch() #37669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2020
Merged

[EventDispatcher] Minor: Avoid not needed null check in dispatch() #37669

merged 1 commit into from
Aug 2, 2020

Conversation

brainexe
Copy link
Contributor
Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
License MIT
Doc PR -

Just found a not needed null check in the heavyly called EventDispatcher::dispatch() method - the $eventName get's always a string now - no null anymore, as it gets the class name instead.

@xabbuh xabbuh added this to the next milestone Jul 27, 2020
@fabpot
Copy link
Member
fabpot commented Aug 2, 2020

Thank you @brainexe.

@fabpot fabpot merged commit 4105e93 into symfony:master Aug 2, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
EventDispatcher Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@brainexe @fabpot @nicolas-grekas @xabbuh @carsonbot
0