8000 [TwigBundle] Fix translator argument for twig.extension.trans by welcoMattic · Pull Request #37472 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[TwigBundle] Fix translator argument for twig.extension.trans #37472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

welcoMattic
Copy link
Member
@welcoMattic welcoMattic commented Jul 1, 2020
Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

I fixed the Translator service argument for Translation Twig Extension, which was a bit hard to debug, because of nullOnInvalid and the anonymous class created in the Extension if Translator is null (https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Twig/Extension/TranslationExtension.php#L50).

@nicolas-grekas
Copy link
Member

Thank you @welcoMattic.

@nicolas-grekas nicolas-grekas merged commit ad94b39 into symfony:master Jul 1, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
@welcoMattic welcoMattic deleted the patch-1 branch July 4, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0