Revert signature change because of possible BC Break

symfony · welcoMattic · Apr 26, 2020 · May 10, 2020 · Jun 29, 2020 · Jun 30, 2020
commit 33f192a49d4d3db7497c4ea65b7d5386c81878a0
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationPushCommandTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationPushCommandTest.php
@@ -110,7 +110,7 @@ function ($path, $catalogue) use ($localMessages) {
                 ->expects($this->any())
                 ->method('read')
                 ->willReturnCallback(
-                    function(array $domains, array $locales) use($remoteMessages) {
+                    function (array $domains, array $locales) use ($remoteMessages) {
                         $translatorBag = new TranslatorBag();
                         foreach ($locales as $locale) {
                             foreach ($domains as $domain) {

diff --git a/src/Symfony/Component/Translation/Bridge/Loco/LocoRemote.php b/src/Symfony/Component/Translation/Bridge/Loco/LocoRemote.php
@@ -14,7 +14,6 @@
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Translation\Exception\TransportException;
 use Symfony\Component\Translation\Loader\LoaderInterface;
-use Symfony\Component\Translation\MessageCatalogue;
 use Symfony\Component\Translation\Remote\AbstractRemote;
 use Symfony\Component\Translation\TranslatorBag;
 use Symfony\Contracts\HttpClient\HttpClientInterface;

diff --git a/src/Symfony/Component/Translation/TranslatorBag.php b/src/Symfony/Component/Translation/TranslatorBag.php
@@ -55,8 +55,12 @@ public function all(): array
         return $messages;
     }
 
-    public function getCatalogue(string $locale): ?MessageCatalogue
+    public function getCatalogue(string $locale = null): ?MessageCatalogue
     {
+        if (null === $locale) {
+            return null;
+        }
+
         return $this->catalogues[$locale] ?? null;
     }
 

diff --git a/src/Symfony/Component/Translation/TranslatorBagInterface.php b/src/Symfony/Component/Translation/TranslatorBagInterface.php
@@ -27,5 +27,5 @@ interface TranslatorBagInterface
      *
      * @throws InvalidArgumentException If the locale contains invalid characters
      */
-    public function getCatalogue(string $locale);
+    public function getCatalogue(string $locale = null);
 }