8000 [PhpUnitBridge] Fix compatibility with phpunit 9.3 by gennadigennadigennadi · Pull Request #37418 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PhpUnitBridge] Fix compatibility with phpunit 9.3 #37418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2020
Merged

[PhpUnitBridge] Fix compatibility with phpunit 9.3 #37418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix: compatibility with phpunit 9.3
  • Loading branch information
@nicolas-grekas
Gennadi Janzen authored and nicolas-grekas committed Jun 28, 2020
commit de71a12f3bc4d7f3f13289f172776fee8bde0f52
10 changes: 8 additions & 2 deletions src/Symfony/Bridge/PhpUnit/Legacy/CommandForV9.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,11 @@
namespace Symfony\Bridge\PhpUnit\Legacy;

use PHPUnit\TextUI\Command as BaseCommand;
use PHPUnit\TextUI\Configuration\Configuration;
use PHPUnit\TextUI\Configuration\Configuration as LegacyConfiguration;
use PHPUnit\TextUI\Configuration\Registry;
use PHPUnit\TextUI\TestRunner as BaseRunner;
use PHPUnit\TextUI\XmlConfiguration\Configuration;
use PHPUnit\TextUI\XmlConfiguration\Loader;
use Symfony\Bridge\PhpUnit\SymfonyTestsListener;

/**
Expand Down Expand Up @@ -43,9 +45,13 @@ protected function createRunner(): BaseRunner

if (isset($this->arguments['configuration'])) {
$configuration = $this->arguments['configuration'];
if (!$configuration instanceof Configuration) {

if (!class_exists(Configuration::class) && !$configuration instanceof LegacyConfiguration) {
$configuration = Registry::getInstance()->get($this->arguments['configuration']);
} elseif (class_exists(Configuration::class) && !$configuration instanceof Configuration) {
$configuration = (new Loader())->load($this->arguments['configuration']);
}

foreach ($configuration->listeners() as $registeredListener) {
if ('Symfony\Bridge\PhpUnit\SymfonyTestsListener' === ltrim($registeredListener->className(), '\\')) {
$registeredLocally = true;
Expand Down
0