8000 Add multiple badges into README by matks · Pull Request #37370 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Add multiple badges into README #37370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add multiple badges into README #37370

wants to merge 1 commit into from

Conversation

matks
Copy link
@matks matks commented Jun 21, 2020 •
edited
Loading
Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

This PR adds multiple badges into the README. Direct badge sources are Travis, and GitHub, and other badges are provided by http://shields.io/ and rely on data sources provided by GitHub, Appveyor and Packagist

Badges are really beautiful 🤩 but also can provide useful informations for people quickly browsing GitHub repositories. They provide popularity and usage KPI and links to the CI tools.

Other possible useful badges I could add in the PR (just tell me):

  • link to the Symfony slack
  • link to Symfony documentation
  • link to Symfony website
    But these would be static badges, not indicating a status / number, just clickable items.

You can see how it would look like by clicking on this link: https://github.com/symfony/symfony/blob/21a6fc51c0e8c412d5c46e341ce6d7f433ce66a4/README.md

@matks
Copy link
Author
matks commented Jun 21, 2020

OK Appveyor tells me the build broke

OK src\Symfony/Bundle/SecurityBundle
PHPUnit 8.3.5 by Sebastian Bergmann and contributors.
Testing src\Symfony/Bundle/FrameworkBundle
...............E...............................................  63 / 900 (  7%)
............................................................... 126 / 900 ( 14%)
............................................................... 189 / 900 ( 21%)
............................................................... 252 / 900 ( 28%)
............................................................... 315 / 900 ( 35%)
............................................................... 378 / 900 ( 42%)
............................................................... 441 / 900 ( 49%)
............................................................... 504 / 900 ( 56%)
.....................SS........................................ 567 / 900 ( 63%)
............................................................... 630 / 900 ( 70%)
............................................................... 693 / 900 ( 77%)
................................................SS............. 756 / 900 ( 84%)
.............................................S................. 819 / 900 ( 91%)
............................................................... 882 / 900 ( 98%)
..................                                              900 / 900 (100%)
Time: 3.23 minutes, Memory: 158.00 MB
There was 1 error:
1) Symfony\Bundle\FrameworkBundle\Tests\Command\CacheClearCommand\CacheClearCommandTest::testCacheIsFreshAfterCacheClearedWithWarmup
Symfony\Component\Filesystem\Exception\IOException: Failed to remove directory "C:\projects\symfony\src\Symfony\Bundle\FrameworkBundle\Tests\Command\CacheClearCommand\Fixture/test": rmdir(C:\projects\symfony\src\Symfony\Bundle\FrameworkBundle\Tests\Command\CacheClearCommand\Fixture/test): Directory not empty
C:\projects\symfony\src\Symfony\Component\Filesystem\Filesystem.php:176
C:\projects\symfony\src\Symfony\Bundle\FrameworkBundle\Tests\Command\CacheClearCommand\CacheClearCommandTest.php:40
ERRORS!
Tests: 900, Assertions: 2549, Errors: 1, Skipped: 5.
KO src\Symfony/Bundle/FrameworkBundle
php phpunit src\Symfony\Component\HttpClient || SET X=!errorlevel!
#!/usr/bin/env php

Did I break the build with a change in the README 😁 ?

Is that some changes on Windows ? 🤔

@wouterj
Copy link
Member
wouterj commented Jun 21, 2020

Please note that Symfony has already rejected badges multiple times in the past:

#8308 (comment)
#21744 (comment)

@fabpot
Copy link
Member
fabpot commented Jun 21, 2020

Thanks for proposing. Closing as it has been rejected multiple times already.

@fabpot fabpot closed this Jun 21, 2020
@matks matks deleted the add-badges-to-readme branch June 21, 2020 19:31
@matks
Copy link
Author
matks commented Jun 21, 2020

No worries, I understand 😊 thanks for fast answer !

@matks
Copy link
Author
matks commented Jun 21, 2020

(on a sidenote, the issue in Ci might be worth looking at, I doubt changing the README was a valid reason for CI to complain)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matks @wouterj @fabpot @carsonbot
0