8000 [request] Move configuration to PHP by dangkhoagms · Pull Request #37287 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[request] Move configuration to PHP #37287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2020
Merged

[request] Move configuration to PHP #37287

merged 1 commit into from
Jun 15, 2020

Conversation

dangkhoagms
Copy link
Contributor
@dangkhoagms dangkhoagms commented Jun 15, 2020 •
edited by Tobion
Loading
Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets Part of #37186
License MIT
Doc PR

Tobion
Tobion suggested changes Jun 15, 2020
View reviewed changes
src/Symfony/Bundle/FrameworkBundle/Resources/config/request.php Outdated
->set('request.add_request_formats_listener')
->class(AddRequestFormatsListener::class)
->tag('kernel.event_subscriber')
->args([abstract_arg('event subscriber')]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abstract_arg('formats')

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the semicolon should be on the next line

Tobion
Tobion suggested changes Jun 15, 2020
View reviewed changes
src/Symfony/Bundle/FrameworkBundle/Resources/config/request.php Outdated
$container->services()
->set('request.add_request_formats_listener', AddRequestFormatsListener::class)
->args([abstract_arg('formats')])
->tag('kernel.event_subscriber');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the simicolon should be on the next line

@Tobion
Copy link
Contributor
Tobion commented Jun 15, 2020

Thank you @dangkhoagms.

@Tobion Tobion merged commit 7838fef into symfony:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rimoi rimoi rimoi left review comments

@Tobion Tobion Tobion approved these changes

Assignees
No one assigned
Labels
Bug Deprecation Feature Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dangkhoagms @Tobion @rimoi @carsonbot
0