[Form] [Doctrine-bridge] Wrong value transformation raises exception #3727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love to have this merged, one of my projects meets this bugs too. |
|
@bschussek ping |
fabpot
added a commit
that referenced
this pull request
Apr 7, 2012
Commits ------- a430f3d [#3446] [Form] Fix getChoicesForValues of EntityChoiceList on empty values Discussion ---------- [Form] Fix reverseTransform on multiple entity form type Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: #3446, #3727 Todo: - --------------------------------------------------------------------------- by stof at 2012-04-03T23:05:55Z @bschussek ping --------------------------------------------------------------------------- by stof at 2012-04-03T23:06:45Z This is an alternate implementation for #3727 --------------------------------------------------------------------------- by chmielot at 2012-04-04T13:47:27Z OK, this is another possibility to fix this issue with working tests. What do you think about this? --------------------------------------------------------------------------- by chmielot at 2012-04-04T13:51:27Z OK, just done. --------------------------------------------------------------------------- by stof at 2012-04-04T13:51:39Z @beberlei @bschussek ping --------------------------------------------------------------------------- by bschussek at 2012-04-06T18:50:37Z @fabpot 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #3446
Todo: Add a unit test
Steps
Calling
Symfony\Component\Form\Extension\Core\DataTransformer\ChoicesToValuesTransformer::reverseTransform()with an empty array as a parameter, when theChoicesToValuesTransformer::$choiceListis aSymfony\Bridge\Doctrine\Form\ChoiceList\EntityChoiceList.Expected behavior
The method returns an empty array.
Observed behavior
A php warning is raised, thus throwing a 500 error
Notes
I didn't write a test because I didn't know where to add it, as the
ChoicesToValuesTransformerbelongs to the Form component, and theEntityChoiceListbelongs to the Doctrine bridge.Also, all the unit test of
ChoicesToValuesTransformerare made on aSymfony\Component\Form\Extension\Core\ChoiceList\SimpleChoiceList, not all the classes implementingSymfony\Component\Form\Extension\Core\ChoiceList\ChoiceList. I think this could be improved so the tests would be more robust, maybe with a PHPUnit provider.Thanks for your time :)