8000 [FrameworkBundle] convert config/serializer.xml to php by mamontovdmitriy · Pull Request #37208 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] convert config/serializer.xml to php #37208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2020
Merged

[FrameworkBundle] convert config/serializer.xml to php #37208

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25df2de
[FrameworkBundle] convert config/serializer.xml to php
mamontovdmitriy Jun 11, 2020
62e9788
make priority integers & fix test checking definition to be private
Tobion Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
make priority integers & fix test checking definition to be private
  • Loading branch information
@Tobion
Tobion committed Jun 21, 2020
commit 62e9788599683cc12a55e0fc885e0e9d4d0ee602
3 changes: 0 additions & 3 deletions src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1465,9 +1465,6 @@ private function registerSerializerConfiguration(array $config, ContainerBuilder
{
$loader->load('serializer.php');

$serializerExtractor = $container->getDefinition('property_info.serializer_extractor');
$serializerExtractor->setPublic(false);

$chainLoader = $container->getDefinition('serializer.mapping.chain_loader');

if (!class_exists(PropertyAccessor::class)) {
Expand Down
22 changes: 11 additions & 11 deletions src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,31 +73,31 @@
// Normalizer
->set('serializer.normalizer.constraint_violation_list', ConstraintViolationListNormalizer::class)
->args([[], service('serializer.name_converter.metadata_aware')])
->tag('serializer.normalizer', ['priority' => '-915'])
->tag('serializer.normalizer', ['priority' => -915])

->set('serializer.normalizer.datetimezone', DateTimeZoneNormalizer::class)
->tag('serializer.normalizer', ['priority' => '-915'])
->tag('serializer.normalizer', ['priority' => -915])

->set('serializer.normalizer.dateinterval', DateIntervalNormalizer::class)
->tag('serializer.normalizer', ['priority' => '-915'])
->tag('serializer.normalizer', ['priority' => -915])

->set('serializer.normalizer.data_uri', DataUriNormalizer::class)
->args([service('mime_types')->nullOnInvalid()])
->tag('serializer.normalizer', ['priority' => '-920'])
->tag('serializer.normalizer', ['priority' => -920])

->set('serializer.normalizer.datetime', DateTimeNormalizer::class)
->tag('serializer.normalizer', ['priority' => '-910'])
10000 ->tag('serializer.normalizer', ['priority' => -910])

->set('serializer.normalizer.json_serializable', JsonSerializableNormalizer::class)
->tag('serializer.normalizer', ['priority' => '-900'])
->tag('serializer.normalizer', ['priority' => -900])

->set('serializer.normalizer.problem', ProblemNormalizer::class)
->args([param('kernel.debug')])
->tag('serializer.normalizer', ['priority' => '-890'])
->tag('serializer.normalizer', ['priority' => -890])

->set('serializer.denormalizer.unwrapping', UnwrappingDenormalizer::class)
->args([service('serializer.property_accessor')])
->tag('serializer.normalizer', ['priority' => '1000'])
->tag('serializer.normalizer', ['priority' => 1000])

->set('serializer.normalizer.object', ObjectNormalizer::class)
->args([
Expand All @@ -109,12 +109,12 @@
null,
[],
])
->tag('serializer.normalizer', ['priority' => '-1000'])
->tag('serializer.normalizer', ['priority' => -1000])

->alias(ObjectNormalizer::class, 'serializer.normalizer.object')

->set('serializer.denormalizer.array', ArrayDenormalizer::class)
->tag('serializer.normalizer', ['priority' => '-990'])
->tag('serializer.normalizer', ['priority' => -990])

// Loader
->set('serializer.mapping.chain_loader', LoaderChain::class)
Expand Down Expand Up @@ -164,7 +164,7 @@
// PropertyInfo extractor
->set('property_info.serializer_extractor', SerializerExtractor::class)
->args([service('serializer.mapping.class_metadata_factory')])
->tag('property_info.list_extractor', ['priority' => '-999'])
->tag('property_info.list_extractor', ['priority' => -999])

// ErrorRenderer integration
->alias('error_renderer', 'error_renderer.serializer')
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,7 +1063,7 @@ public function testRegisterSerializerExtractor()
$serializerExtractorDefinition = $container->getDefinition('property_info.serializer_extractor');

$this->assertEquals('serializer.mapping.class_metadata_factory', $serializerExtractorDefinition->getArgument(0)->__toString());
$this->assertFalse($serializerExtractorDefinition->isPublic());
$this->assertTrue(!$serializerExtractorDefinition->isPublic() || $serializerExtractorDefinition->isPrivate());
$tag = $serializerExtractorDefinition->getTag('property_info.list_extractor');
$this->assertEquals(['priority' => -999], $tag[0]);
}
Expand Down
0