8000 [Config] Removed implicit cast of ReflectionProperty to string by derrabus · Pull Request #36896 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Config] Removed implicit cast of ReflectionProperty to string #36896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2020
Merged

[Config] Removed implicit cast of ReflectionProperty to string #36896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Config] Removed implicit cast of ReflectionProperty to string.
  • Loading branch information
@derrabus
derrabus committed May 22, 2020
commit 8adbadede7716ffbea90a5fdc4bcb3444258ab9c
6 changes: 5 additions & 1 deletion src/Symfony/Component/Config/Resource/ReflectionClassResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,11 @@ private function generateSignature(\ReflectionClass $class)
$defaults = $class->getDefaultProperties();

foreach ($class->getProperties(\ReflectionProperty::IS_PUBLIC | \ReflectionProperty::IS_PROTECTED) as $p) {
yield $p->getDocComment().$p;
yield $p->getDocComment();
yield $p->isDefault() ? '<default>' : '';
yield $p->isPublic() ? 'public' : 'protected';
yield $p->isStatic() ? 'static' : '';
yield '$'.$p->name;
yield print_r(isset($defaults[$p->name]) && !\is_object($defaults[$p->name]) ? $defaults[$p->name] : null, true);
}
}
Expand Down
0