8000 [Form] Add choice_translation_parameters option for ChoiceType form by VincentLanglet · Pull Request #36851 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Add choice_translation_parameters option for ChoiceType form #36851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

[Form] Add choice_translation_parameters option for ChoiceType form #36851

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0bdc12a
Add choice_translation_parameters option
VincentLanglet May 18, 2020
5c9a613
Add changelog
VincentLanglet May 18, 2020
53958d7
Fix tests
VincentLanglet May 18, 2020
5cea241
Avoid BC-break
VincentLanglet Jul 7, 2020
3c48b9a
Make choice_translation_parameters similar to choice_attr and support…
VincentLanglet Jul 12, 2020
e87b938
Bump version
VincentLanglet Aug 23, 2020
2762e67
Avoid BC break
VincentLanglet Sep 20, 2020
47875df
Add deprecation
VincentLanglet Sep 27, 2020
026ed90
Fix test
VincentLanglet Oct 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add deprecation
  • Loading branch information
@VincentLanglet
VincentLanglet committed Oct 4, 2020
commit 47875dff3cf5d161c63782429fa4ae3da8928f0c
4 changes: 4 additions & 0 deletions src/Symfony/Component/Form/ChoiceList/Factory/CachingFactoryDecorator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,10 @@ public function createListFromLoader(ChoiceLoaderInterface $loader, $value = nul
*/
public function createView(ChoiceListInterface $list, $preferredChoices = null, $label = null, $index = null, $groupBy = null, $attr = null/*, $labelTranslationParameters = []*/)
{
if (\count(\func_get_args()) < 7) {
trigger_deprecation('symfony/form', '5.2', 'Calling %s without passing the label translation parameters is deprecated.', __METHOD__);
}

$labelTranslationParameters = \func_get_args()[6] ?? [];
$cache = true;

Expand Down
4 changes: 4 additions & 0 deletions src/Symfony/Component/Form/ChoiceList/Factory/DefaultChoiceListFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ public function createListFromLoader(ChoiceLoaderInterface $loader, callable $va
*/
public function createView(ChoiceListInterface $list, $preferredChoices = null, $label = null, callable $index = null, callable $groupBy = null, $attr = null/*, $labelTranslationParameters = []*/)
{
if (\count(\func_get_args()) < 7) {
trigger_deprecation('symfony/form', '5.2', 'Calling %s without passing the label translation parameters is deprecated.', __METHOD__);
}

$labelTranslationParameters = \func_get_args()[6] ?? [];
$preferredViews = [];
$preferredViewsOrder = [];
Expand Down
4 changes: 4 additions & 0 deletions src/Symfony/Component/Form/ChoiceList/Factory/PropertyAccessDecorator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,10 @@ public function createListFromLoader(ChoiceLoaderInterface $loader, $value = nul
*/
public function createView(ChoiceListInterface $list, $preferredChoices = null, $label = null, $index = null, $groupBy = null, $attr = null/*, $labelTranslationParameters = []*/)
{
if (\count(\func_get_args()) < 7) {
trigger_deprecation('symfony/form', '5.2', 'Calling %s without passing the label translation parameters is deprecated.', __METHOD__);
}

$labelTranslationParameters = \func_get_args()[6] ?? [];
$accessor = $this->propertyAccessor;

Expand Down
0