[TwigBundle] Deprecate the public "twig" service to private #36739
Conversation
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function build(ContainerBuilder $container) |
There was a problem hiding this comment.
Since this test bundle is used with different configurations, it's easier to register those controllers as services here (it avoids duplication in config files).
|
|
||
| public function __construct(ContainerInterface $container) | ||
| { | ||
| $this->container = $container; |
There was a problem hiding this comment.
why not inject dependencies explicitly?
There was a problem hiding this comment.
I tried to modify existing tests the least possible. I mean I tried to keep $container->get. I guess we can inject the dependencies as well.
There was a problem hiding this comment.
Using the service subscriber system looks OK to me 🤷♂️
| @@ -40,7 +40,7 @@ public function testBundlePublicDir() | |||
| public function testBundleTwigTemplatesDir() | |||
| { | |||
| static::bootKernel(['test_case' => 'BundlePaths']); | |||
| $twig = static::$container->get('twig'); | |||
| $twig = static::$container->get('twig.alias'); | |||
There was a problem hiding this comment.
can't we get private services in tests with the special test container? why is this needed?
There was a problem hiding this comment.
The twig service is still public. We don't want to access to it directly to avoid the deprecation.
cf53d43 to
1490baa
Compare
1490baa to
c278d09
Compare
c278d09 to
f64cbad
Compare
|
@fabpot Done. |
|
Thank you @fancyweb. |
I think the
twigservice don't need to be public anymore - we never need to access it directly in Symfony's code.