10000 [SecurityBundle] Fixed entry point service ID resolving and multiple guard entry points by wouterj · Pull Request #36661 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[SecurityBundle] Fixed entry point service ID resolving and multiple guard entry points #36661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2020
Merged

[SecurityBundle] Fixed entry point service ID resolving and multiple guard entry points #36661

merged 2 commits into from
May 3, 2020

Conversation

wouterj
Copy link
Member
@wouterj wouterj commented May 2, 2020 •
edited
Loading
Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR n/a

@fabpot I am not able to reproduce the error you reported in any of my demo applications or in the tests introduced in this PR. The error indicates that no entry point is configured in your application, can you maybe try out this patch (given it now makes a hard error when more than one guard is used)? If it still doesn't work, can you maybe share your firewall configuration?

build failures are unrelated

@wouterj wouterj force-pushed the security/fix-entry_point-pr branch from 6c8ab3f to f75893a Compare May 2, 2020 11:53
@wouterj wouterj force-pushed the security/fix-entry_point-pr branch from f75893a to 6870a18 Compare May 2, 2020 13:04
@fabpot
Copy link
Member
fabpot commented May 2, 2020

Found it: https://github.com/symfony/symfony/pull/36575/files#r418984315

@wouterj wouterj mentioned this pull request May 2, 2020
Merged
@wouterj
Copy link
Member Author
wouterj commented May 2, 2020

I've reverted the AbstractFactory BC breaks in this PR.

@wouterj wouterj force-pushed the security/fix-entry_point-pr branch from b9d76cc to c756593 Compare May 2, 2020 18:59
@fabpot
Copy link
Member
fabpot commented May 3, 2020

Thank you @wouterj.

@fabpot fabpot merged commit 28bb74c into symfony:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug SecurityBundle Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wouterj @fabpot @carsonbot
0