8000 Add support of PHP8 static return type for withers by l-vo · Pull Request #36636 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Add support of PHP8 static return type for withers #36636

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2020
Merged

Add support of PHP8 static return type for withers #36636

merged 1 commit into from
May 3, 2020

Conversation

l-vo
Copy link
Contributor
@l-vo l-vo commented Apr 30, 2020 •
edited
Loading
Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets https://github.com/orgs/symfony/projects/1#card-35852557
License MIT
Doc PR symfony/symfony-docs#13619

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 30, 2020
nicolas-grekas
nicolas-grekas reviewed Apr 30, 2020
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I just realized the check should also verify that @return $this is NOT present.
We really miss the $this return type, which would provide much better clarity and would save us many annotations.
With the current state, we'll still have to use docblocks to help differentiate those two situations.

/cc @nikic FYI, in case this can be considered for PHP v8

@l-vo l-vo force-pushed the detect_php8_static_returntype_for_withers branch 5 times, most recently from ab722c1 to d586092 Compare April 30, 2020 14:15
@l-vo
Copy link
Contributor Author
l-vo commented Apr 30, 2020

Updated 🙂

@l-vo l-vo force-pushed the detect_php8_static_returntype_for_withers branch from d586092 to 345a294 Compare April 30, 2020 14:55
@l-vo
Copy link
Contributor Author
l-vo commented Apr 30, 2020

I still have a problem on travis 7.2/php_extra=7.4, my check on PHP_VERSION_ID seems not working on this environment 🤔 Do I miss something specific to this environment ?

@nicolas-grekas
Copy link
Member

You need to list the new file in .github/patch-types.php

@l-vo l-vo force-pushed the detect_php8_static_returntype_for_withers branch 2 times, most recently from 28cd280 to 6cea5da Compare April 30, 2020 20:04
nicolas-grekas
8000
nicolas-grekas reviewed Apr 30, 2020
View reviewed changes
@l-vo l-vo force-pushed the detect_php8_static_returntype_for_withers branch from 6cea5da to 04fdf05 Compare April 30, 2020 20:10
@l-vo
Copy link
Contributor Author
l-vo commented Apr 30, 2020

Updated 🙂

@fabpot
Copy link
Member
fabpot commented May 3, 2020

Thank you @l-vo.

@fabpot fabpot merged commit eebb3ef into symfony:master May 3, 2020
@fabpot fabpot mentioned this pull request May 3, 2020
Closed
@l-vo l-vo deleted the detect_php8_static_returntype_for_withers branch May 3, 2020 19:42
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
@derrabus derrabus mentioned this pull request Sep 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@l-vo @nicolas-grekas @fabpot @carsonbot
0