8000 [Security] Integrated Guards with the Authenticator system by wouterj · Pull Request #36570 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] Integrated Guards with the Authenticator system #36570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2020
Merged

[Security] Integrated Guards with the Authenticator system #36570

merged 1 commit into from
Apr 25, 2020

Conversation

wouterj
Copy link
Member
@wouterj wouterj commented Apr 24, 2020 •
edited
Loading
Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

This way, the guard configuration (and guard authenticators) can use the new authenticator system as well. Advantages:

  • Any bundle providing guard integration (e.g. Lexik JWT, Knp Oauth) can now integrate with the authenticator system as well
  • (after we've integrated LDAP as well) Anyone can set security.enable_authenticator_manager: true to test the new experimental system without needing to update any PHP code.

cc @weaverryan

@wouterj wouterj changed the title Integrated Guards with the Authenticator system [Security] Integrated Guards with the Authenticator system Apr 24, 2020
@wouterj wouterj force-pushed the security/new-system-guard branch from b0b5136 to 985c70c Compare April 24, 2020 16:49
@wouterj wouterj force-pushed the security/new-system-guard branch from 985c70c to 8708a6c Compare April 24, 2020 17:08
chalasr
chalasr approved these changes Apr 25, 2020
View reviewed changes
Copy link
Member
@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Worth a CHANGELOG entry?

@chalasr chalasr added this to the next milestone Apr 25, 2020
@wouterj
Copy link
Member Author
wouterj commented Apr 25, 2020 •
edited
Loading

Worth a CHANGELOG entry?

We only have a CHANGELOG file in symfony/security and we didn't document any other new authenticator there as well (only "hey, we wrote a complete new system"). Do you want me to add an entry with all new authenticators?

@chalasr
Copy link
Member
chalasr commented Apr 25, 2020

Ok thanks, nothing to do then :)
Ready to go on my side.

@fabpot
Copy link
Member
fabpot commented Apr 25, 2020

Thank you @wouterj.

@fabpot fabpot mentioned this pull request Apr 25, 2020
Closed
@fabpot fabpot merged commit 6b48511 into symfony:master Apr 25, 2020
@wouterj wouterj deleted the security/new-system-guard branch April 25, 2020 14:39
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@wouterj @chalasr @fabpot @nicolas-grekas @carsonbot
0