[RFC][Routing] fix or trick ? #3651
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR
/foo-{bar}-{baz}
matches/foo-b/ar-b-az
I thought I was a great idea when I wrote it, I am not sure any more:
b/ar
is a BC break, it should probably not be included in 2.0. However I think this is the expected behavior (but it also suffers from the problem? mentioned below)b-az
is a new feature (could it be considered as a BC break as such ?)One issue I can see with matching
b-az
is that it would hide a/foo-{bar}-{baz}-{buz}
route declared afterwards. However a it would a masked a/foo-{bar}-{baz}_{buz}
even with the current code. So one "benefit" here is to be consistent.