8000 Remove return type for Twig function workflow_metadata() by gisostallenberg · Pull Request #36447 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Remove return type for Twig function workflow_metadata() #36447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Remove return type for Twig function workflow_metadata() #36447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove return type for Twig function workflow_metadata() 
Technically it is allowed to have metadata other than string, even data that does not cast to string, like an array.
Also see #36391
  • Loading branch information
@gisostallenberg
gisostallenberg committed Apr 14, 2020
commit 55664c5a17ecdb5d291df21a10a9b87675130bb5
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/Twig/Extension/WorkflowExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public function getMarkedPlaces($subject, $placesNameOnly = true, $name = null)
* Use a string (the place name) to get place metadata
* Use a Transition instance to get transition metadata
*/
public function getMetadata($subject, string $key, $metadataSubject = null, string $name = null): ?string
public function getMetadata($subject, string $key, $metadataSubject = null, string $name = null)
{
return $this
->workflowRegistry
Expand Down
0