8000 [Messenger] Add FIFO support to the SQS transport by cv65kr · Pull Request #36431 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Add FIFO support to the SQS transport #36431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2020
Merged

[Messenger] Add FIFO support to the SQS transport #36431

merged 1 commit into from
Apr 17, 2020

Conversation

cv65kr
Copy link
Contributor
@cv65kr cv65kr commented Apr 11, 2020
Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets no
License MIT
Doc PR --

https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/FIFO-queues.html

@cv65kr cv65kr requested a review from sroze as a code owner April 11, 2020 22:02
@cv65kr cv65kr force-pushed the feature/messenger/sqs-support-fifo branch 2 times, most recently from 3975263 to 8ab8980 Compare April 11, 2020 22:05
@nicolas-grekas nicolas-grekas changed the title FIFO support for SQS [Messenger] FIFO support for SQS Apr 12, 2020
@nicolas-grekas nicolas-grekas changed the title [Messenger] FIFO support for SQS [Messenger] Add FIFO support to the SQS transport Apr 12, 2020
@nicolas-grekas nicolas-grekas added this to the next milestone Apr 12, 2020
chalasr
chalasr reviewed Apr 12, 2020
View reviewed changes
Copy link
Member
@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. ping @jderusse

Nyholm
Nyholm requested changes Apr 12, 2020
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like @jderusse idea by using a stamp to configure FIFO parameters.

@cv65kr
Copy link
Contributor Author
cv65kr commented Apr 12, 2020

@jderusse @Nyholm good point! updated.

jderusse
jderusse approved these changes Apr 12, 2020
View reviewed changes
Copy link
Member
@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small comment

Nyholm
Nyholm requested changes Apr 13, 2020
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.

Im happy with this after the fix suggest 8000 ed by @jderusse

@cv65kr
Copy link
Contributor Author
cv65kr commented Apr 13, 2020

@jderusse @Nyholm updated, thanks for review.

@cv65kr cv65kr force-pushed the feature/messenger/sqs-support-fifo branch from 27d5847 to ff9a8ee Compare April 13, 2020 12:23
Nyholm
Nyholm approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you!

This looks like a great first contribution.

@fabpot fabpot force-pushed the feature/messenger/sqs-support-fifo branch from ff9a8ee to 3760175 Compare April 17, 2020 03:34
@fabpot
Copy link
Member
fabpot commented Apr 17, 2020

Thank you @cv65kr.

@fabpot fabpot mentioned this pull request Apr 17, 2020
Closed
@fabpot fabpot merged commit 67948a7 into symfony:master Apr 17, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@jderusse jderusse jderusse approved these changes

@Nyholm Nyholm Nyholm approved these changes

@chalasr chalasr chalasr approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Feature Messenger Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
7 participants
@cv65kr @fabpot @nicolas-grekas @jderusse @Nyholm @chalasr @carsonbot
< 2A24 footer class="footer pt-8 pb-6 f6 color-fg-muted p-responsive" role="contentinfo" >

Footer

© 2025 GitHub, Inc.
0