8000 [Form] Deprecated unused old `ServerParams` util by HeahDude · Pull Request #36426 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Deprecated unused old ServerParams util #36426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2020
Merged

[Form] Deprecated unused old ServerParams util #36426

merged 1 commit into from
Apr 12, 2020

Conversation

HeahDude
Copy link
Contributor
Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? yes
Tickets ~
License MIT
Doc PR ~

A left over after #11924 (comment), this class is unused since Symfony 2.3 ^^'. I've noticed it before but never took the time to submit a PR because this is very minor IMHO. But since this deprecation should not impact anyone, let's keep the codebase clean and remove it in 6.0.

@HeahDude HeahDude requested a review from xabbuh as a code owner April 11, 2020 18:11
@HeahDude HeahDude force-pushed the form/deprecate-old_server_params branch 2 times, most recently from 4a556bd to 611f45c Compare April 11, 2020 20:25
@nicolas-grekas nicolas-grekas added this to the next milestone Apr 12, 2020
@HeahDude HeahDude force-pushed the form/deprecate-old_server_params branch from 611f45c to e05e924 Compare April 12, 2020 13:23
@fabpot
Copy link
Member
fabpot commented Apr 12, 2020

Thank you @HeahDude.

@fabpot fabpot merged commit 7800a2a into symfony:master Apr 12, 2020
@fabpot fabpot mentioned this pull request Apr 12, 2020
Closed
@HeahDude HeahDude deleted the form/deprecate-old_server_params branch April 12, 2020 13:58
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@Tobion Tobion Tobion left review comments

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Deprecation Form Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@HeahDude @fabpot @nicolas-grekas @Tobion @carsonbot
0