[ErrorHandler] Remove trigger_deprecation frame from trace #36329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Apr 3, 2020
| @@ -468,6 +468,8 @@ public function handleError(int $type, string $message, string $file, int $line) | |||
| return true; | |||
| } | |||
| } else { | |||
| $this->handleTriggerDeprecationFunction(debug_backtrace(0), $type, $file, $line); | |||
There was a problem hiding this comment.
Should we reuse this backtrace instead of calling $exception->getTrace() later? I don't know when exception backtraces are "generated". So I did not touch it.
|
I borrowed your test case in #36353 |
fabpot
added a commit
that referenced
this pull request
Apr 12, 2020
…ce (fancyweb, nicolas-grekas) This PR was merged into the 5.1-dev branch. Discussion ---------- [ErrorHandler] Remove trigger_deprecation frame from trace | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This accounts for the new `trigger_deprecation` function from [symfony/deprecation-contracts](https://github.com/symfony/deprecation-contracts). Replaces #36329 Commits ------- d4eb4a4 [ErrorHandler] Remove trigger_deprecation frame from trace (add tests) c293aee [ErrorHandler] Remove trigger_deprecation frame from trace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not modify the
cleanTracemethod because it is also used for silenced errors. However, deprecations cannot be silenced. So it seems better to me to create a new method and use it when it is needed. Also we need to know the modified line and file before creating the exception. So we cannot use the exception trace, unless we create the exception twice. I don't know what is better performance wise: let me know!