10000 [HttpKernel] Deprecate single-colon notation for controllers by chalasr · Pull Request #36257 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] Deprecate single-colon notation for controllers #36257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2020
Merged

[HttpKernel] Deprecate single-colon notation for controllers #36257

merged 1 commit into from
Mar 31, 2020

Conversation

chalasr
Copy link
Member
@chalasr chalasr commented Mar 29, 2020 •
edited by nicolas-grekas
Loading
Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? yes
Tickets -
License MIT
Doc PR todo

@chalasr chalasr added this to the next milestone Mar 29, 2020
@chalasr chalasr force-pushed the ctrl-single-colon branch 2 times, most recently from b1a6b70 to 955618e Compare March 31, 2020 12:13
@chalasr
Copy link
Member Author
chalasr commented Mar 31, 2020

Ready

nicolas-grekas
nicolas-grekas reviewed Mar 31, 2020
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing CHANGELOG entry :)

@chalasr chalasr force-pushed the ctrl-single-colon branch from 955618e to e88cec6 Compare March 31, 2020 19:21
@chalasr
Copy link
Member Author
chalasr commented Mar 31, 2020

CHANGELOG updated

@nicolas-grekas
Copy link
Member

Thank you @chalasr.

@nicolas-grekas nicolas-grekas mentioned this pull request Mar 31, 2020
Closed
@nicolas-grekas nicolas-grekas merged commit 9381dd6 into symfony:master Mar 31, 2020
@chalasr chalasr deleted the ctrl-single-colon branch March 31, 2020 20:46
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Deprecation HttpKernel Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@chalasr @nicolas-grekas @fabpot @carsonbot
0