8000 [AmazonSqsMessenger] Use AsyncAws to handle SQS communication by jderusse · Pull Request #36094 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[AmazonSqsMessenger] Use AsyncAws to handle SQS communication #36094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2020
Merged

[AmazonSqsMessenger] Use AsyncAws to handle SQS communication #36094

merged 1 commit into from
May 3, 2020

Conversation

jderusse
Copy link
Member
Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets /
License MIT
Doc PR /

Similar to #35992 this PR use AsyncAws to handle Sqs messages sent/receive

It move complexity of authentication/streaming outside Symfony while keeping HttpClient integration.

@jderusse jderusse requested a review from sroze as a code owner March 16, 2020 12:29
@Nyholm
Copy link
Member
Nyholm commented Mar 16, 2020

If I run my application on a lambda or EC2, there is no authentication configuration required in Symfony.

It will automatically pick up the predefined environment variables. Of course I need to configure the application's role in AWS.

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 19, 2020
@jderusse jderusse mentioned this pull request Apr 12, 2020
Closed
1 task
@Nyholm Nyholm mentioned this pull request Apr 12, 2020
Closed
10 tasks
@chalasr
Copy link
Member
chalasr commented Apr 13, 2020

LGTM 👍 (once rebased)

@jderusse jderusse force-pushed the sqs branch 2 times, most recently from 49c0c68 to 1f96595 Compare April 15, 2020 20:01
@chalasr
Copy link
Member
chalasr commented Apr 23, 2020

@jderusse Seems like the low-deps job is still failing https://travis-ci.org/github/symfony/symfony/jobs/678251415#L5486, any idea?
Needs another rebase also :)

@jderusse
Copy link
Member Author

Rebased. But I think we should wait for AsyncAws version 1.0 before merging.

@jderusse jderusse force-pushed the sqs branch 3 times, most recently from 2aaec99 to dacb784 Compare April 23, 2020 10:30
Nyholm
Nyholm approved these changes May 3, 2020
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I had some minor suggestions.

👍

@jderusse jderusse force-pushed the sqs branch 2 times, most recently from 69a06e7 to de779a0 Compare May 3, 2020 15:48
Nyholm
Nyholm approved these changes May 3, 2020
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im happy with the PR now

@fabpot
Copy link
Member
fabpot commented May 3, 2020

Thank you @jderusse.

@fabpot fabpot mentioned this pull request May 3, 2020
Closed
@fabpot fabpot merged commit 017420b into symfony:master May 3, 2020
@jderusse jderusse deleted the sqs branch May 3, 2020 17:21
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@Nyholm Nyholm Nyholm approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Feature Messenger Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
6 participants
@jderusse @Nyholm @chalasr @fabpot @nicolas-grekas @carsonbot
0