8000 [Mime] remove phpdoc mentioning Utf8AddressEncoder by dmaicher · Pull Request #35999 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Mime] remove phpdoc mentioning Utf8AddressEncoder #35999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

dmaicher
Copy link
Contributor
@dmaicher dmaicher commented Mar 8, 2020

This class does not exist

Q A
Branch? 4.3
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

I'm currently migrating from Swiftmailer fo Symfony mailer and stumbled upon this exception:

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Mime/Encoder/IdnAddressEncoder.php#L44

The phpdoc of the class is a bit confusing/wrong. Seems to be a copy&paste leftover from Swiftmailer:

https://github.com/swiftmailer/swiftmailer/blob/master/lib/classes/Swift/AddressEncoder/IdnAddressEncoder.php#L19

@fabpot fabpot changed the base branch from 4.3 to 4.4 March 9, 2020 12:55
@fabpot
Copy link
Member
fabpot commented Mar 9, 2020

Thank you @dmaicher.

@fabpot fabpot merged commit 14b825b into symfony:4.4 Mar 9, 2020
@dmaicher dmaicher deleted the patch-2 branch March 9, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0