8000 [Messenger] Add ext-redis min version req to tests by ogizanagi · Pull Request #35980 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Add ext-redis min version req to tests #35980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2020
Merged

[Messenger] Add ext-redis min version req to tests #35980

merged 1 commit into from
Mar 5, 2020

Conversation

ogizanagi
Copy link
Contributor
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

Properly skip the test instead of:

Testing src/Symfony/Component/Messenger
E                                                                   1 / 1 (100%)

Time: 597 ms, Memory: 16.00 MB

There was 1 error:

1) Symfony\Component\Messenger\Tests\Transport\RedisExt\RedisTransportFactoryTest::testCreateTransport
Symfony\Component\Messenger\Exception\LogicException: The redis transport requires php-redis 4.3.0 or higher.

@ogizanagi ogizanagi added this to the 4.4 milestone Mar 5, 2020
@ogizanagi ogizanagi requested a review from sroze as a code owner March 5, 2020 15:36
@fabpot
Copy link
Member
fabpot commented Mar 5, 2020

Thank you @ogizanagi.

@fabpot fabpot merged commit ff30b43 into symfony:4.4 Mar 5, 2020
@ogizanagi ogizanagi deleted the fix-test-redis-req branch March 5, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ogizanagi @fabpot @chalasr @carsonbot
0