8000 [String] move symfony/translation-contracts to require-dev by nicolas-grekas · Pull Request #35948 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[String] move symfony/translation-contracts to require-dev #35948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2020
Merged

[String] move symfony/translation-contracts to require-dev #35948

merged 1 commit into from
Mar 4, 2020

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Since it's needed only if AsciiSlugger is used.
Surprisingly, the code in FrameworkExtension deals with this as if the dep was already optional:

symfony/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Lines 217 to 220 in 210ea22

if (!interface_exists(LocaleAwareInterface::class)) {
$container->register('slugger', 'stdClass')
->addError('You cannot use the "slugger" service since the Translation contracts are not installed. Try running "composer require symfony/translation".');
}

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 3, 2020
@fabpot
Copy link
Member
fabpot commented Mar 4, 2020

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 7c90c8b into symfony:master Mar 4, 2020
@nicolas-grekas nicolas-grekas deleted the str-req-dev branch March 13, 2020 11:29
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
6D21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@AdrianDeAnda AdrianDeAnda AdrianDeAnda approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @fabpot @AdrianDeAnda @carsonbot
0