[FrameworkBundle] Add missing items in the unused tag pass whitelist #35833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
218a291 to
714e913
Compare
714e913 to
bcbeada
Compare
OskarStark
reviewed
Feb 23, 2020
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/UnusedTagsPass.php
Show resolved
Hide resolved
007d105 to
6e0e8a7
Compare
yceruto
approved these changes
Feb 23, 2020
src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/UnusedTagsPassTest.php
Show resolved
Hide resolved
6e0e8a7 to
2bbce4e
Compare
…nused tag whitelist
2bbce4e to
d1bcc0f
Compare
|
Thank you @fabpot. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 25, 2020
…ss whitelist (fabpot) This PR was merged into the 5.1-dev branch. Discussion ---------- [FrameworkBundle] Add missing items in the unused tag pass whitelist | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | n/a <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | n/a We have some missing tags in the whitelist. I've added a script that adds the missing ones, and added a test to avoid forgetting about updating the whitelist. Commits ------- d1bcc0f [FrameworkBundle] Add a script that checks for missing items in the unused tag whitelist
nicolas-grekas
added a commit
that referenced
this pull request
Feb 25, 2020
* 3.4: minor #35833 [FrameworkBundle] Add missing items in the unused tag pass whitelist (fabpot) [Validator] Add missing translations
nicolas-grekas
added a commit
that referenced
this pull request
Feb 25, 2020
* 4.4: minor #35833 [FrameworkBundle] Add missing items in the unused tag pass whitelist (fabpot) [HttpClient][DX] Add URL context to JsonException messages [Routing] Improve localized routes performances [4.4][DoctrineBridge] Use new Types::* constants and support new json type [Validator] Add missing translations [Messenger] Use Doctrine DBAL new Types::* constants
nicolas-grekas
added a commit
that referenced
this pull request
Feb 25, 2020
* 5.0: minor #35833 [FrameworkBundle] Add missing items in the unused tag pass whitelist (fabpot) [HttpClient][DX] Add URL context to JsonException messages [Routing] Improve localized routes performances [4.4][DoctrineBridge] Use new Types::* constants and support new json type [Validator] Add missing translations [Notifier] Dispatch message event in null transport [Messenger] Use Doctrine DBAL new Types::* constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some missing tags in the whitelist. I've added a script that adds the missing ones, and added a test to avoid forgetting about updating the whitelist.