-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Asset] Allows to download asset manifest over HTTP #35762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
src/Symfony/Component/Asset/Tests/VersionStrategy/RemoteJsonManifestVersionStrategyTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\Asset\Tests\VersionStrategy; | ||
|
|
||
| use PHPUnit\Framework\TestCase; | ||
| use Symfony\Component\Asset\VersionStrategy\RemoteJsonManifestVersionStrategy; | ||
| use Symfony\Component\HttpClient\Exception\JsonException; | ||
| use Symfony\Component\HttpClient\MockHttpClient; | ||
| use Symfony\Component\HttpClient\Response\MockResponse; | ||
|
|
||
| class RemoteJsonManifestVersionStrategyTest extends TestCase | ||
| F438 { | ||
| public function testGetVersion() | ||
| { | ||
| $strategy = $this->createStrategy('https://cdn.example.com/manifest-valid.json'); | ||
|
|
||
| $this->assertSame('main.123abc.js', $strategy->getVersion('main.js')); | ||
| } | ||
|
|
||
| public function testApplyVersion() | ||
| { | ||
| $strategy = $this->createStrategy('https://cdn.example.com/manifest-valid.json'); | ||
|
|
||
| $this->assertSame('css/styles.555def.css', $strategy->getVersion('css/styles.css')); | ||
| } | ||
|
|
||
| public function testApplyVersionWhenKeyDoesNotExistInManifest() | ||
| { | ||
| $strategy = $this->createStrategy('https://cdn.example.com/manifest-valid.json'); | ||
|
|
||
| $this->assertSame('css/other.css', $strategy->getVersion('css/other.css')); | ||
| } | ||
|
|
||
| public function testMissingManifestFileThrowsException() | ||
| { | ||
| $this->expectException('RuntimeException'); | ||
| $this->expectExceptionMessage('HTTP 404 returned for "https://cdn.example.com/non-existent-file.json"'); | ||
| $strategy = $this->createStrategy('https://cdn.example.com/non-existent-file.json'); | ||
| $strategy->getVersion('main.js'); | ||
| } | ||
|
|
||
| public function testManifestFileWithBadJSONThrowsException() | ||
| { | ||
| $this->expectException(JsonException::class); | ||
| $this->expectExceptionMessage('Syntax error'); | ||
| $strategy = $this->createStrategy('https://cdn.example.com/manifest-invalid.json'); | ||
| $strategy->getVersion('main.js'); | ||
| } | ||
|
|
||
| private function createStrategy($manifestUrl) | ||
| { | ||
| $httpClient = new MockHttpClient(function ($method, $url, $options) { | ||
| $filename = __DIR__.'/../fixtures/'.basename($url); | ||
|
|
||
| if (file_exists($filename)) { | ||
| return new MockResponse(file_get_contents($filename), ['http_headers' => ['content-type' => 'application/json']]); | ||
| } | ||
|
|
||
| return new MockResponse('{}', ['http_code' => 404]); | ||
| }); | ||
|
|
||
| return new RemoteJsonManifestVersionStrategy($manifestUrl, $httpClient); | ||
| } | ||
| } |
62 changes: 62 additions & 0 deletions
62
src/Symfony/Component/Asset/VersionStrategy/RemoteJsonManifestVersionStrategy.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\Asset\VersionStrategy; | ||
|
|
||
| use Symfony\Contracts\HttpClient\HttpClientInterface; | ||
|
|
||
| /** | ||
| * Reads the versioned path of an asset from a remote JSON manifest file. | ||
| * | ||
| * For example, the manifest file might look like this: | ||
| * { | ||
| * "main.js": "main.abc123.js", | ||
| * "css/styles.css": "css/styles.555abc.css" | ||
| * } | ||
| * | ||
| * You could then ask for the version of "main.js" or "css/styles.css". | ||
| */ | ||
| class RemoteJsonManifestVersionStrategy implements VersionStrategyInterface | ||
| { | ||
| private $manifestData; | ||
| private $manifestUrl; | ||
| private $httpClient; | ||
|
|
||
| /** | ||
| * @param string $manifestUrl Absolute URL to the manifest file | ||
| */ | ||
| public function __construct(string $manifestUrl, HttpClientInterface $httpClient) | ||
| { | ||
| $this->manifestUrl = $manifestUrl; | ||
| $this->httpClient = $httpClient; | ||
| } | ||
|
|
||
| /** | ||
| * With a manifest, we don't really know or care about what | ||
| * the version is. Instead, this returns the path to the | ||
| * versioned file. | ||
| */ | ||
| public function getVersion(string $path) | ||
| { | ||
| return $this->applyVersion($path); | ||
| } | ||
|
|
||
| public function applyVersion(string $path) | ||
| { | ||
| if (null === $this->manifestData) { | ||
| $this->manifestData = $this->httpClient->request('GET', $this->manifestUrl, [ | ||
| 'headers' => ['accept' => 'application/json'], | ||
| ])->toArray(); | ||
| } | ||
|
|
||
| return $this->manifestData[$path] ?? $path; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.