[HttpKernel] Make ErrorListener unaware of the event dispatcher #35635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Feb 7, 2020
src/Symfony/Component/HttpKernel/EventListener/ErrorListener.php
Outdated
Show resolved
Hide resolved
8c8ae6f to
a9d1ded
Compare
|
Done. The Travis failure looks unrelated. |
Tobion
approved these changes
Feb 8, 2020
fabpot
approved these changes
Feb 8, 2020
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Feb 8, 2020
…ispatcher (derrabus) This PR was merged into the 5.1-dev branch. Discussion ---------- [HttpKernel] Make ErrorListener unaware of the event dispatcher | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Under certain circumstances, HttpKernel's `ErrorListener` class might dynamically register and unregister a listener with the dispatcher. If our goal is to make the dispatcher immutable, that specific behavior would be in our way. Also, #34988 would break this workflow. This PR provides an alternative. The listener is always registered, but I'm using the request to piggyback a flag that activates/deactivates the listener. Commits ------- a9d1ded [HttpKernel] Make ErrorListener unaware of the event dispatcher.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain circumstances, HttpKernel's
ErrorListenerclass might dynamically register and unregister a listener with the dispatcher. If our goal is to make the dispatcher immutable, that specific behavior would be in our way. Also, #34988 would break this workflow.This PR provides an alternative. The listener is always registered, but I'm using the request to piggyback a flag that activates/deactivates the listener.