8000 [Security] Be able to know the reasons of the denied access by maidmaid · Pull Request #35592 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] Be able to know the reasons of the denied access #35592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

[Security] Be able to know the reasons of the denied access #35592

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
26a8381
poc
maidmaid Jan 8, 2020
868b9ff
round 2
maidmaid Feb 18, 2020
edfc392
Add a "~" default filter in profiler twig view
maidmaid Mar 3, 2020
ec41df2
Fix the message deprecated
maidmaid Mar 3, 2020
842e59e
Fix a typo
maidmaid Mar 3, 2020
7339108
Fix a typo
maidmaid Mar 3, 2020
8ef8d19
Make final the Vote and the AccessDecision classes
maidmaid Mar 3, 2020
c8a360c
Fix minor
maidmaid Mar 3, 2020
c4cfb5f
Add phpdoc
maidmaid Mar 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the message deprecated 
Co-Authored-By: Antoine Makdessi <antoine.makdessi@agriconomie.com>
  • Loading branch information
@maidmaid @noniagriconomie
maidmaid and noniagriconomie authored Mar 3, 2020
commit ec41df2b4fdbe26d8844fd49a4eb182147e25bbf
2 changes: 1 addition & 1 deletion src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ private function decideIfAllAbstainDecisions(): AccessDecision
private function vote(VoterInterface $voter, TokenInterface $token, $subject, array $attributes): Vote
{
if (\is_int($vote = $voter->vote($token, $subject, $attributes))) {
trigger_deprecation('symfony/security', 5.1, 'Returning an int from the "%s::vote()" method is deprecated. Return a "" object instead.', \get_class($this->voter), Vote::class);
trigger_deprecation('symfony/security', 5.1, 'Returning an int from the "%s::vote()" method is deprecated. Return a "%s" object instead.', \get_class($this->voter), Vote::class);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
trigger_deprecation('symfony/security', 5.1, 'Returning an int from the "%s::vote()" method is deprecated. Return a "%s" object instead.', \get_class($this->voter), Vote::class);
trigger_deprecation('symfony/security-core', 5.1, 'Returning an int from the "%s::vote()" method is deprecated, return a "%s" object instead.', \get_class($this->voter), Vote::class);

$vote = Vote::create($vote);
}

Expand Down
0