8000 [FrameworkBundle] added new parameter router.request_context.url by pyatnitsev · Pull Request #35580 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] added new parameter router.request_context.url #35580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[FrameworkBundle] added new parameter router.request_context.url #35580

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84ba43d
[FrameworkBundle] added new parameter router.request_context.url
pyatnitsev Feb 3, 2020
ed1bf47
[FrameworkBundle] fixed code standards
pyatnitsev Feb 3, 2020
7465340
[FrameworkBundle] fixed code standards
pyatnitsev Feb 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[FrameworkBundle] fixed code standards
  • Loading branch information
@pyatnitsev
pyatnitsev committed Feb 3, 2020
commit ed1bf4784b7e2d5f3e087d5c14f76271de9ded1d
3 changes: 1 addition & 2 deletions src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/RequestContextPass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,12 @@
use Symfony\Component\DependencyInjection\ContainerBuilder;

/**
* Add support of url property for routing generator
* Add support of url property for routing generator.
*
* @author Danil Pyatnitsev <danil@pyatnitsev.ru>
*/
class RequestContextPass implements CompilerPassInterface
{

public function process(ContainerBuilder $container)
{
if (false === $container->hasParameter('router.request_context.url')) {
Expand Down
17 changes: 10 additions & 7 deletions ...fony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/RequestContextPassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
<?php
/**
* Created by PhpStorm.
* User: Danil Pyatnitsev
* Date: 03.02.2020
* Time: 22:12

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection\Compiler;
Expand Down Expand Up @@ -40,7 +43,7 @@ public function testRouterRequestContextUrlParseWithoutBaseUrlTest()

$this->assertEquals('foo.example.com', $container->getParameter('router.request_context.host'));
$this->assertEquals('https', $container->getParameter('router.request_context.scheme'));
$this->assertEquals(false, $container->hasParameter('router.request_context.base_url'));
$this->assertFalse(false, $container->hasParameter('router.request_context.base_url'));
$this->assertEquals('8080', $container->getParameter('request_listener.https_port'));
}
}
}
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ protected static function getBundleDefaultConfig()
'host' => '%router.request_context.host%',
'scheme' => '%router.request_context.scheme%',
'base_url' => '%router.request_context.base_url%',
'url' => '%router.request_context.url%'
'url' => '%router.request_context.url%',
],
],
'session' => [
Expand Down
0