[Console][QuestionHelper] Use String width() to properly move the cursor backwards #35578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2020
fabpot
added a commit
that referenced
this pull request
Feb 7, 2020
This PR was merged into the 5.1-dev branch. Discussion ---------- [String] Remove the @experimental status | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #35578 (comment) | License | MIT | Doc PR | - Commits ------- 3d15f91 [String] Remove the @experimental status
nicolas-grekas
added a commit
that referenced
this pull request
Feb 7, 2020
This PR was merged into the 5.1-dev branch. Discussion ---------- [String] Add the s() helper method | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | #35578 (comment) | License | MIT | Doc PR | - This method will be useful in our code base, and to anyone that doesn't really understand the differences between UnicodeString and ByteString. Commits ------- 659cdf1 [String] Add the s() helper method
cd34a17 to
67a1f55
Compare
chalasr
approved these changes
Feb 11, 2020
nicolas-grekas
approved these changes
Feb 11, 2020
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Feb 11, 2020
…ove the cursor backwards (fancyweb) This PR was merged into the 5.1-dev branch. Discussion ---------- [Console][QuestionHelper] Use String width() to properly move the cursor backwards | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #35536 (comment) | License | MIT | Doc PR | - This bug can only be fixed on master since we need to require the String component. Once the component is required, we can iterate in the Console component to use it more where it is needed. Commits ------- 67a1f55 [Console][QuestionHelper] Use String width() to properly move the cursor backwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no cha
309E
nges were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug can only be fixed on master since we need to require the String component. Once the component is required, we can iterate in the Console component to use it more where it is needed.