8000 [HttpClient] fix HttpClientDataCollector when handling canceled responses by nicolas-grekas · Pull Request #35562 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpClient] fix HttpClientDataCollector when handling canceled responses #35562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2020
Merged

[HttpClient] fix HttpClientDataCollector when handling canceled responses #35562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[HttpClient] fix HttpClientDataCollector when handling canceled respo… 
…nses
  • Loading branch information
@nicolas-grekas
nicolas-grekas committed Feb 2, 2020
commit 303f9e5be5176a114ae82e4ed3eeeb15bf329252
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ private function collectOnClient(TraceableHttpClient $client): array

unset($info['filetime'], $info['http_code'], $info['ssl_verify_result'], $info['content_type']);

if ($trace['method'] === $info['http_method']) {
if (($info['http_method'] ?? null) === $trace['method']) {
unset($info['http_method']);
}

Expand Down
0