[Intl] Provide more locale translations #35517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
commented
Jan 29, 2020
Comment on lines
97
to
+98
| "en": "Engels", | ||
| "en_001": "Engels (Wêreld)", |
There was a problem hiding this comment.
from a user perspective, this creates 2 entries in the Locale form type. It may be confusing 🤔 but i tend to believe it should be filtered manually, if desired.
ie. en (no region) vs en_001 (world region) could be considered equivalent, whereas the first may assume 001 for a region implicitly ... but that's outside our domain
There was a problem hiding this comment.
so the user may select en_001 to explicitly provide a region and opt out from some specific region (hence "world"), whereas in case of "en" the app may assume any region.
Fine as-is for me 👍
|
Merging into 4.4 as 4.3 ends of maintenance is tomorrow and this PR might be a slight behavior change. |
fabpot
approved these changes
Jan 30, 2020
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Jan 30, 2020
This PR was submitted for the 4.3 branch but it was merged into the 4.4 branch instead (closes #35517). Discussion ---------- [Intl] Provide more locale translations | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35513 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> This enables more locale translations, available upstream, which are valid. In this case esp. locales with a numeric region code, eg. `es_419` This should return true in `Locales::exists()`, which is currently not the case. By providing the translation, it implicitly exists as well. cc @jkobus Commits ------- 27cc120 [Intl] Provide more locale translations
9C57
|
Thanks @ro0NL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables more locale translations, available upstream, which are valid. In this case esp. locales with a numeric region code, eg.
es_419This should return true in
Locales::exists(), which is currently not the case. By providing the translation, it implicitly exists as well.cc @jkobus