8000 [Messenger] Check for all serialization exceptions during message dec… by waaghals · Pull Request #35480 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Check for all serialization exceptions during message dec… #35480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2020
Merged

[Messenger] Check for all serialization exceptions during message dec… #35480

merged 1 commit into from
Jan 29, 2020

Conversation

waaghals
Copy link
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35446
License MIT

Makes it so that the Messenger Serializer throws a MessageDecodingFailedException for any serializer exception.

@waaghals waaghals requeste 8000 d a review from sroze as a code owner January 27, 2020 12:46
Nyholm
Nyholm requested changes Jan 28, 2020
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Just a minor fix and I'll be happy to approve.

@Nyholm
Copy link
Member
Nyholm commented Jan 28, 2020

Also, make sure that fabbot.io is happy. =)

Nyholm
Nyholm approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm requested a review from Tobion January 29, 2020 10:33
Tobion
Tobion approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor
@Tobion Tobion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be merged in 4.3

@Tobion Tobion changed the base branch from 4.4 to 4.3 January 29, 2020 12:59
@Tobion
Copy link
Contributor
Tobion commented Jan 29, 2020

Thank you @waaghals.

Tobion added a commit that referenced this pull request Jan 29, 2020
@Tobion
bug #35480 [Messenger] Check for all serialization exceptions during …
14c3555 
…message dec… (Patrick Berenschot)

This PR was merged into the 4.3 branch.

Discussion
----------

[Messenger] Check for all serialization exceptions during message dec…

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #35446
| License       | MIT

Makes it so that the Messenger Serializer throws a `MessageDecodingFailedException` for any serializer exception.

Commits
-------

21fffca [Messenger] Check for all serialization exceptions during message dec…
@Tobion Tobion merged commit 21fffca into symfony:4.3 Jan 29, 2020
This was referenced Jan 31, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on Gi 70CB tHub. Already have an account? Sign in to comment
Reviewers

@Tobion Tobion Tobion approved these changes

@Nyholm Nyholm Nyholm approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waaghals @Nyholm @Tobion @carsonbot
0