[ErrorHandler] Add debug argument to decide whether debug page is shown or not #35464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8718a8 to
bc045a0
Compare
c749df4 to
cf80224
Compare
|
@nicolas-grekas I've simplied it a bit more. |
|
Thank you @yceruto. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 27, 2020
…page is shown or not (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorHandler] Add debug argument to decide whether debug page is shown or not | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35448 | License | MIT | Doc PR | - This ensures that the debug page (with stack trace) won't be (by default) displayed in non-CLI context when an early error occurs (after FB::boot()) in non-debug mode (prod). And `Debug::enable()` will enable it explicitly. Commits ------- cf80224 Added debug argument to decide if debug page should be shown or not
PhilETaylor
pushed a commit
to PhilETaylor/symfony
that referenced
this pull request
Sep 6, 2023
… debug page is shown or not (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorHandler] Add debug argument to decide whether debug page is shown or not | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix symfony#35448 | License | MIT | Doc PR | - This ensures that the debug page (with stack trace) won't be (by default) displayed in non-CLI context when an early error occurs (after FB::boot()) in non-debug mode (prod). And `Debug::enable()` will enable it explicitly. Commits ------- cf80224 Added debug argument to decide if debug page should be shown or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the debug page (with stack trace) won't be (by default) displayed in non-CLI context when an early error occurs (after FB::boot()) in non-debug mode (prod). And
Debug::enable()will enable it explicitly.