8000 [Workflow] Make many internal services as hidden by lyrixx · Pull Request #35321 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Workflow] Make many internal services as hidden #35321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2020
Merged

[Workflow] Make many internal services as hidden #35321

merged 1 commit into from
Jan 13, 2020

Conversation

lyrixx
Copy link
Member
@lyrixx lyrixx commented Jan 13, 2020 •
edited
Loading
Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #35197
License MIT
Doc PR

I "removed":

  • transitions
  • auto-generated guard listener (when enable via the configuration)
  • auto-generated audit trail listener (when enable via the configuration)

I kept

  • the registry
  • the workflow (of course)
  • its definition: I know people are using it
  • workflow.twig_extension the twig extension because all others twig extensions are not hidden - but could IMHO
  • the default marking store
  • the command to dump the workflow (SVG)
  • The local expression language
  • abstract workflow definition for the workflow and state machine

@nicolas-grekas nicolas-grekas added this to the next milestone Jan 13, 2020
@nicolas-grekas
Copy link
Member

For the generated ids, I think this is OK, but for the static names, isn't this a BC break?

@lyrixx
Copy link
Member Author
lyrixx commented Jan 13, 2020

For the generated ids, I think this is OK, but for the static names, isn't this a BC break?

I don't know. You tell me :)

@lyrixx
Copy link
Member Author
lyrixx commented Jan 13, 2020

For the generated ids, I think this is OK, but for the static names, isn't this a BC break?

reverted

@fabpot
Copy link
Member
fabpot commented Jan 13, 2020

Thank you @lyrixx.

@fabpot fabpot mentioned this pull request Jan 13, 2020
Closed
fabpot added a commit that referenced this pull request Jan 13, 2020
@fabpot
feature #35321 [Workflow] Make many internal services as hidden (lyrixx)
0607691 
This PR was merged into the 5.1-dev branch.

Discussion
----------

[Workflow] Make many internal services as hidden

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #35197
| License       | MIT
| Doc PR        |

I "removed":

* transitions
* auto-generated guard listener  (when enable via the configuration)
* auto-generated audit trail listener (when enable via the configuration)
* abstract workflow definition for the workflow and state machine

I kept
* the registry
* the workflow (of course)
* its definition: I know people are using it
* `workflow.twig_extension` the twig extension because all others twig extensions are not hidden - but could IMHO
* the default marking store
* the command to dump the workflow (SVG)
* The local expression language

Commits
-------

b4776d6 [Workflow] Make many internal services as hidden
@fabpot fabpot merged commit b4776d6 into symfony:master Jan 13, 2020
@lyrixx lyrixx deleted the w-hidden branch January 13, 2020 13:59
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed Workflow
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Workflow] Hide internal services
5 participants
@lyrixx @nicolas-grekas @fabpot @stof @carsonbot
0